fix(sdk): Constrain skill findings to diff hunk line range#151
Merged
Conversation
Findings with startLine outside the hunk range get rejected by GitHub's API (422) when posted as inline PR comments. Add prompt constraints telling the LLM to anchor findings within the hunk, plus a defense-in-depth filter that drops out-of-range findings after extraction. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename local getHunkLineRange to formatHunkLineRange since it produces a display string, removing the need for the getHunkNumericRange import alias. Extract isWithinHunk helper for readability. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
This likely isnt good enough but its an improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterOutOfRangeFindings()inanalyzeHunkthat drops findings withstartLineoutside the hunk range after extraction, with Sentry breadcrumb loggingFixes #150
Test plan
pnpm lint && pnpm build && pnpm testpasses🤖 Generated with Claude Code