Skip to content

Conversation

@loewenheim
Copy link
Contributor

#skip-changelog

@loewenheim loewenheim self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #810 (83950b7) into master (11472bf) will decrease coverage by 0.02%.
The diff coverage is 73.33%.

❗ Current head 83950b7 differs from pull request most recent head 60195ee. Consider uploading reports for the commit 60195ee to get more accurate results

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   74.88%   74.86%   -0.02%     
==========================================
  Files          63       63              
  Lines       15649    15654       +5     
==========================================
+ Hits        11718    11719       +1     
- Misses       3931     3935       +4     

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess clippy still doesn’t like it :-(

Cow::Owned(inner) => Cow::Owned($f(&inner).to_owned()),
}
};
fn resolve_cow<'f>(map: &'f BcSymbolMap<'_>, s: Cow<'f, str>) -> Cow<'f, str> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice! I wonder when that borrow checker problem was fixed.

@loewenheim loewenheim enabled auto-merge (squash) September 6, 2023 08:42
@loewenheim
Copy link
Contributor Author

I guess clippy still doesn’t like it :-(

It was just let-else formatting.

@loewenheim loewenheim merged commit cc88c50 into master Sep 6, 2023
@loewenheim loewenheim deleted the fix/clippy branch September 6, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants