feat: change SourceBundleWriter::write_object_with_filter() filter callback to take SourceCode
#764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vaind
force-pushed
the
feat/bundle-filter-by-type
branch
from
e67ecd2 to
1d093f5
Compare
vaind
changed the title
SourceCode in write_object_with_filter()SourceBundleWriter::write_object_with_filter() filter callback to take SourceCode
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 74.19% 74.22% +0.02%
==========================================
Files 70 70
Lines 15112 15117 +5
==========================================
+ Hits 11213 11220 +7
+ Misses 3899 3897 -2 |
loewenheim
reviewed
Feb 21, 2023
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
loewenheim
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of getsentry/sentry-cli#1482
This enables Sentry-CLI to filter out embedded sources while collecting referenced files.