Repository navigation
fix(wasm): Don't artificially extend symbol sizes - #1081
Merged
Merged
Conversation
I believe artificially extending every symbol to the start of the next even if we have a size value can only make things worse. According to the comment this was done for parity with a library we were previously using, but I don't think it's necessary anymore.
elramen
approved these changes
Sep 23, 2026
Dav1dde
approved these changes
Sep 23, 2026
Dav1dde
left a comment
Dav1dde
left a comment
Member
There was a problem hiding this comment.
I stumbled across this before and was close to removing this as well 👍
loewenheim
enabled auto-merge (squash)
September 23, 2026 12:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe artificially extending every symbol to the start of the next even if we have a size value can only make things worse. According to the comment this was done for parity with a library we were previously using, but I don't think it's necessary anymore.