Improve support for sentry-java #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
7 tasks
Shubhdeep12
requested changes
Feb 12, 2024
Collaborator
There was a problem hiding this comment.
Hi @markushi added some suggestions, let make type attribute separate for both types of event - Error event and transaction.
Shubhdeep12
reviewed
Feb 13, 2024
packages/overlay/src/integrations/sentry/components/Events/Event.tsx
Outdated
Show resolved
Hide resolved
Shubhdeep12
reviewed
Feb 13, 2024
packages/overlay/src/integrations/sentry/data/sentryDataCache.ts
Outdated
Show resolved
Hide resolved
dcramer
pushed a commit
that referenced
this pull request
Jun 3, 2025
* Improve support for sentry-java * Add changeset * Address PR feedback * Add java txn fixture envelope * Move message to CommonEventAttrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the Java/Android SDK side for spotlight integration getsentry/sentry-java#3166 I stumbled upon two issues which caused spotlight to crash:
sentry-javasends over "Message" events, which contain a top level message object, that clashes with themessage: stringof error eventsJS is not my proficiency, happy for any PR feedback!
Before opening this PR:
pnpm changeset:add