-
-
Notifications
You must be signed in to change notification settings - Fork 32
build(release): migrate to Craft #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f5754ad
41587ee
e850d38
f518553
21675af
ce4339b
22d75f7
42d2991
54ecc54
ed2a94f
3c9e98e
95d2a0e
eef79fc
ca733ce
2c810ce
7f00ff0
e7e989b
39dc3f5
f5f2164
467afc1
d489298
b95ee97
45ace77
c0e997e
3467ee2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Craft Release Configuration | ||
| # https://getsentry.github.io/craft/configuration/ | ||
|
|
||
| minVersion: "2.16.0" | ||
|
|
||
| versioning: | ||
| policy: auto | ||
|
|
||
| changelog: | ||
| filePath: packages/spotlight/CHANGELOG.md | ||
| policy: auto | ||
|
|
||
| preReleaseCommand: bash scripts/bump-version.sh | ||
|
|
||
| statusProvider: | ||
| name: github | ||
| config: | ||
| contexts: | ||
| - "Build" | ||
|
|
||
| requireNames: | ||
| - /^built-packages$/ | ||
| - /^spotlight-binaries$/ | ||
| - /^electron-binaries$/ | ||
|
|
||
| targets: | ||
| - name: npm | ||
| id: spotlight | ||
| path: packages/spotlight | ||
|
|
||
| - name: github | ||
| tagPrefix: "@spotlightjs/spotlight@" | ||
betegon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| includeNames: /^(spotlight-|Spotlight|latest-).*|.*\.(yml|blockmap)$/ | ||
|
|
||
| - name: docker | ||
| source: ghcr.io/getsentry/spotlight | ||
| target: ghcr.io/getsentry/spotlight | ||
BYK marked this conversation as resolved.
Show resolved
Hide resolved
betegon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: docker | ||
| source: ghcr.io/getsentry/spotlight | ||
| target: | ||
| image: ghcr.io/getsentry/spotlight | ||
| format: "{{{image}}}:latest" | ||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,15 @@ | |||||||||||||||||||||||||||||
| # Changelog Preview workflow | |||||||||||||||||||||||||||||
| # Shows how PRs will appear in the changelog | |||||||||||||||||||||||||||||
| # https://getsentry.github.io/craft/ | |||||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||||
| name: Changelog Preview | |||||||||||||||||||||||||||||
| on: | |||||||||||||||||||||||||||||
| pull_request: | |||||||||||||||||||||||||||||
| types: [opened, synchronize, reopened, edited, labeled, unlabeled] | |||||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||||
| jobs: | |||||||||||||||||||||||||||||
| changelog-preview: | |||||||||||||||||||||||||||||
| name: Preview Changelog | |||||||||||||||||||||||||||||
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2 | |||||||||||||||||||||||||||||
| secrets: inherit | |||||||||||||||||||||||||||||
|
Comment on lines
+12
to
+14
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
Copilot AutofixAI 6 days ago To fix the problem, add an explicit The best way to fix this without changing existing functionality is:
Concretely:
permissions:
contents: readNo imports or additional methods are required, as this is a YAML configuration change only.
Suggested changeset
1
.github/workflows/changelog-preview.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Refresh and try again.
|
|||||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status context mismatch may prevent Craft release
Medium Severity
The
statusProvider.contextsconfiguration specifies"Build"as the required status context. However, GitHub Actions status checks are typically named using the format{workflow-name} / {job-name}. Since the workflow is named"Build & Test"and the job is named"Build", the actual status check context will be"Build & Test / Build". If Craft requires an exact match, it won't detect when the build completes, potentially blocking releases. The context should likely be"Build & Test / Build"or use a pattern that matches the full status check name.