Skip to content

feat(profiling): Create profiling datasets by default in self-hosted #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2023

Conversation

phacops
Copy link
Contributor

@phacops phacops commented May 17, 2023

This will create the datasets needed to use profiling in self-hosted.

@phacops phacops requested a review from a team as a code owner May 17, 2023 14:11
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -1.93 ⚠️

Comparison is base (e171d33) 92.21% compared to head (a78c4c2) 90.29%.

❗ Current head a78c4c2 differs from pull request most recent head 50bc4e9. Consider uploading reports for the commit 50bc4e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4195      +/-   ##
==========================================
- Coverage   92.21%   90.29%   -1.93%     
==========================================
  Files         741      775      +34     
  Lines       37155    38423    +1268     
  Branches        0      225     +225     
==========================================
+ Hits        34264    34694     +430     
- Misses       2891     3694     +803     
- Partials        0       35      +35     
Impacted Files Coverage Δ
snuba/consumers/consumer.py 86.06% <0.00%> (-0.27%) ⬇️
snuba/settings/__init__.py 94.44% <100.00%> (ø)

... and 47 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phacops phacops changed the title feat(profiling): Create profiling datasets feat(profiling): Create profiling datasets by default in self-hosted May 17, 2023
@phacops phacops merged commit 0489f0a into master May 17, 2023
@phacops phacops deleted the pierre/profiling-do-not-skip-profiling-migrations branch May 17, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants