dev(generic-metrics) run generic-metrics consumers in dev #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhars
reviewed
Jul 15, 2022
| @@ -215,6 +215,30 @@ def devserver(*, bootstrap: bool, workers: bool) -> None: | |||
| "--consumer-group=snuba-metrics-consumers", | |||
| ], | |||
| ), | |||
| ( | |||
There was a problem hiding this comment.
Do you want to use the same settings flag we use for release health metrics or use a different flag settings.ENABLE_SENTRY_METRICS_DEV? Will there be a use case where someone wants to run just one of release health metrics vs performance metrics?
To enable the indexer in Sentry for release health vs performance metrics, is there a single setting or different settings? Maybe it might be a good idea to keep it consistent.
There was a problem hiding this comment.
I did in fact copy the single-setting behavior from Sentry (Markus added this recently to help local e2e testing): getsentry/sentry#36682
nikhars
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables developers to automatically run generic metrics consumers for testing metrics-enhanced performance locally
tested in my local environment