-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(emerge): Add git info to frontend #97457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
3c7e73c
to
8f3af74
Compare
feac969
to
94ac7bd
Compare
8f3af74
to
f15e0c7
Compare
94ac7bd
to
91c2113
Compare
trevor-e
approved these changes
Aug 8, 2025
91c2113
to
5875175
Compare
f15e0c7
to
4843228
Compare
Base automatically changed from
ryan/add_new_vcs_fields_to_builddetails_api
to
master
August 8, 2025 16:15
4843228
to
6844302
Compare
value: buildDetailsData.vcs_info.base_repo_name, | ||
}, | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: VCS Info Access and PR Number Type Issues
The commit introduces two issues:
- Optional chaining was removed from
vcs_info
object accesses, potentially causing runtime errors ifvcs_info
isnull
orundefined
. - The
pr_number
field has a type inconsistency, returningnumber
orstring
('-'
) instead of consistentlystring
, unlike other fields. It should be explicitly converted to a string.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
<img width="520" height="720" alt="image" src="https://github.com/user-attachments/assets/f849d89c-9599-403a-923b-d86eae055217" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.