Skip to content

feat(aci): add issue category data condition #94677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ameliahsu
Copy link
Member

this is a legacy condition that we still have to account for due to migrated workflows

@ameliahsu ameliahsu requested a review from a team as a code owner June 30, 2025 23:55
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 30, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Default Comparison Causes Runtime Errors

The ISSUE_CATEGORY data condition entry in dataConditionNodesMap is missing a defaultComparison property. Without it, IssueCategoryDetails and IssueCategoryNode components attempt to access condition.comparison.value when condition.comparison is undefined for new conditions, leading to runtime errors. A defaultComparison (e.g., {value: GroupCategory.ERROR}) should be added, consistent with other configurable conditions.

static/app/views/automations/components/dataConditionNodes.tsx#L159-L167

],
[
DataConditionType.ISSUE_CATEGORY,
{
label: t('Issue category'),
dataCondition: IssueCategoryNode,
details: IssueCategoryDetails,
},
],

static/app/views/automations/components/actionFilters/issueCategory.tsx#L31-L33

category:
GROUP_CATEGORY_CHOICES.find(choice => choice.value === condition.comparison.value)
?.label || condition.comparison.value,

static/app/views/automations/components/actionFilters/issueCategory.tsx#L42-L43

name={`${condition_id}.comparison.value`}
value={condition.comparison.value}

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant