fix: DataCategoryExact should match Relay #94663
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
| @@ -748,15 +748,12 @@ export enum CreditType { | |||
| ERROR = 'error', | |||
| TRANSACTION = 'transaction', | |||
| SPAN = 'span', | |||
| SPAN_INDEXED = 'spanIndexed', | |||
There was a problem hiding this comment.
removed all the ones that don't exist in the backend
| SPAN_INDEXED = 'spanIndexed', | ||
| PROFILE_DURATION = 'profileDuration', | ||
| PROFILE_DURATION_UI = 'profileDurationUI', | ||
| PROFILE_DURATION = 'profile_duration', |
There was a problem hiding this comment.
this was the wrong format the whole time; credit types are serialized in lower case snake case
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94663 +/- ##
=======================================
Coverage 79.24% 79.24%
=======================================
Files 10422 10422
Lines 603079 603079
Branches 23470 23470
=======================================
Hits 477893 477893
Misses 124680 124680
Partials 506 506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-972/make-datacategoryexact-consistent
Hence the name :)