fix(taskworker): Check registry before creating task namespace in tests #94659
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enochtangg
changed the title
john-z-yang
approved these changes
Jun 30, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #94659 +/- ##
==========================================
+ Coverage 79.24% 85.24% +6.00%
==========================================
Files 10422 10424 +2
Lines 603079 603103 +24
Branches 23470 23470
==========================================
+ Hits 477893 514111 +36218
+ Misses 124680 88240 -36440
- Partials 506 752 +246 |
john-z-yang
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
I think this is a good temporary fix to unblock us, but maybe there was another test that created the test_namespace but did not unregister it in the tearDown method. When the tests got shuffled, that test did not run first so it caused this one to fail.
Let me see if I can find tests that are doing that
Comment on lines
14
to
+19
| def setUp(self): | ||
| super().setUp() | ||
| self.namespace = registry.create_namespace(name="test_namespace") | ||
| if not registry.contains("test_namespace"): | ||
| self.namespace = registry.create_namespace(name="test_namespace") | ||
| else: | ||
| self.namespace = registry.get("test_namespace") |
There was a problem hiding this comment.
tests shouldn't be irreversibly modifying global state -- the correct fix is to undo the mutation in a teardown rather than making this idempotent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently broken. This PR is responsible for fixing the set up for
TestTaskworkerRolloutby ensuring to not re-create the task namespace if it already exists.