ref(alerts): Pull code out into smaller functions

[ceorourke]

We're using a lot of flags and processing regular metric alerts, dynamic metric alerts, and workflow engine - the code in process_update was getting difficult to read. This PR pulls out some code into their own functions to make it more readable.

[codecov]

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/incidents/subscription_processor.py	96.07%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #94654    +/-   ##
========================================
  Coverage   87.92%   87.93%            
========================================
  Files       10418    10422     +4     
  Lines      602751   603144   +393     
  Branches    23451    23451            
========================================
+ Hits       529993   530363   +370     
- Misses      72252    72275    +23     
  Partials      506      506            

[ceorourke]

cursor might be right but I didn't change anything - can address if it's a bug later

[cursor]

Bug: Metric Recording Inconsistency

In handle_trigger_anomalies, the metrics.incr call for resolve events was reordered to occur after trigger_resolve_threshold. This prevents the resolve metric from being recorded if trigger_resolve_threshold raises an exception. This behavior is inconsistent with handle_trigger_alerts, where metrics are incremented before the trigger call.

src/sentry/incidents/subscription_processor.py#L288-L293

sentry/src/sentry/incidents/subscription_processor.py

Lines 288 to 293 in eef2373

	if not has_anomaly and self.active_incident and trigger_matches_status:
	incident_trigger = self.trigger_resolve_threshold(trigger, aggregation_value)
	metrics.incr(
	"incidents.alert_rules.threshold.resolve",
	tags={"detection_type": self.alert_rule.detection_type},
	)

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎