Skip to content

feat(replay): Create an Audit Log for bulk Replay Deletes inside /settings #94653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Jun 30, 2025

Desc Img
No permissions SCR-20250630-mire
Empty SCR-20250630-mjij
With data SCR-20250630-mhei

I'm not thinking about throwing this behind a feature flag because it's very straight forward, stands alone (although there's no data yet), and the audit part should probably always be visible even if the action/button is enabled/disabled via feature flag.

Fixes REPLAY-458

@ryan953 ryan953 requested a review from a team as a code owner June 30, 2025 20:49
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 30, 2025
@aliu39 aliu39 requested a review from cmanallen June 30, 2025 22:40
Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not thinking about throwing this behind a feature flag

We haven't really tested it yet so I'm somewhat worried about exposing it straight away. I think its fine but I haven't done a real, large-scale test of it yet. The endpoint isn't feature flagged but I figure if you're taking the trouble to make a curl request you're probably tolerant of failures. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants