-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(replay): Create an Audit Log for bulk Replay Deletes inside /settings #94653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Michelle Zhang <56095982+michellewzhang@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not thinking about throwing this behind a feature flag
We haven't really tested it yet so I'm somewhat worried about exposing it straight away. I think its fine but I haven't done a real, large-scale test of it yet. The endpoint isn't feature flagged but I figure if you're taking the trouble to make a curl request you're probably tolerant of failures. Wdyt?
I'm not thinking about throwing this behind a feature flag because it's very straight forward, stands alone (although there's no data yet), and the audit part should probably always be visible even if the action/button is enabled/disabled via feature flag.
Fixes REPLAY-458