Skip to content

🔧 chore: remove pr comments ff logic #94650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔧 chore: remove pr comments ff logic #94650

wants to merge 1 commit into from

Conversation

iamrajjoshi
Copy link
Member

its GA-ed. ill clean up the actually ff in a followup

@iamrajjoshi iamrajjoshi self-assigned this Jun 30, 2025
@iamrajjoshi iamrajjoshi requested review from a team as code owners June 30, 2025 20:36
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 30, 2025
Copy link

codecov bot commented Jun 30, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
27124 1 27123 249
View the top 1 failed test(s) by shortest run time
tests.sentry.integrations.github.tasks.test_open_pr_comment.TestSafeForComment::test_simple
Stack Traces | 8.17s run time
#x1B[1m#x1B[.../github/tasks/test_open_pr_comment.py#x1B[0m:122: in test_simple
    assert pr_files == [
#x1B[1m#x1B[31mE   AssertionError: assert [{'changes': ...: 'modified'}] == [{'changes': ...: 'modified'}]#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Left contains one more item: {'changes': 100, 'filename': 'raj.cs', 'status': 'modified'}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       [#x1B[0m
#x1B[1m#x1B[31mE           {#x1B[0m
#x1B[1m#x1B[31mE               'changes': 100,#x1B[0m
#x1B[1m#x1B[31mE               'filename': 'foo.py',#x1B[0m
#x1B[1m#x1B[31mE               'status': 'modified',#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE           {#x1B[0m
#x1B[1m#x1B[31mE               'changes': 100,#x1B[0m
#x1B[1m#x1B[31mE               'filename': 'bar.js',#x1B[0m
#x1B[1m#x1B[31mE               'status': 'modified',#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE           {#x1B[0m
#x1B[1m#x1B[31mE               'changes': 100,#x1B[0m
#x1B[1m#x1B[31mE               'filename': 'bop.php',#x1B[0m
#x1B[1m#x1B[31mE               'status': 'modified',#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE           {#x1B[0m
#x1B[1m#x1B[31mE               'changes': 100,#x1B[0m
#x1B[1m#x1B[31mE               'filename': 'doo.rb',#x1B[0m
#x1B[1m#x1B[31mE               'status': 'modified',#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE     +     {#x1B[0m
#x1B[1m#x1B[31mE     +         'changes': 100,#x1B[0m
#x1B[1m#x1B[31mE     +         'filename': 'raj.cs',#x1B[0m
#x1B[1m#x1B[31mE     +         'status': 'modified',#x1B[0m
#x1B[1m#x1B[31mE     +     },#x1B[0m
#x1B[1m#x1B[31mE       ]#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants