Skip to content

chore(issues): Clean up traceparent experiment #93894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrduncan merged 1 commit into from
Jun 20, 2025
Merged

chore(issues): Clean up traceparent experiment #93894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/sentry/grouping/strategies/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,6 @@
from sentry.eventstore.models import Event

REGEX_PATTERN_KEYS = (
"email",
"url",
"hostname",
"ip",
"uuid",
"sha1",
"md5",
"date",
"duration",
"hex",
"float",
"int",
"quoted_str",
"bool",
)

REGEX_PATTERN_KEYS_WITH_TRACEPARENT = (
"email",
"url",
"hostname",
Expand Down Expand Up @@ -104,11 +87,6 @@ def _should_run_experiment(experiment_name: str) -> bool:
parameterizer = Parameterizer(
regex_pattern_keys=REGEX_PATTERN_KEYS, experiments=(UniqueIdExperiment,)
)
if _should_run_experiment("traceparent"):
parameterizer = Parameterizer(
regex_pattern_keys=REGEX_PATTERN_KEYS_WITH_TRACEPARENT,
experiments=(UniqueIdExperiment,),
)

normalized = parameterizer.parameterize_all(trimmed, _should_run_experiment)

Expand Down
4 changes: 2 additions & 2 deletions tests/sentry/grouping/test_parameterization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
Parameterizer,
UniqueIdExperiment,
)
from sentry.grouping.strategies.message import REGEX_PATTERN_KEYS_WITH_TRACEPARENT
from sentry.grouping.strategies.message import REGEX_PATTERN_KEYS


@pytest.fixture
def parameterizer():
return Parameterizer(
regex_pattern_keys=REGEX_PATTERN_KEYS_WITH_TRACEPARENT,
regex_pattern_keys=REGEX_PATTERN_KEYS,
experiments=(UniqueIdExperiment,),
)

Expand Down