Skip to content

fix(crons): Expand trace id column header width #93285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

MichaelSun48
Copy link
Member

Fixes RTC-1009

Expands the width of the traceId column header to be the same as the body cell width:

Screenshot 2025-06-10 at 2 59 22 PM

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner June 10, 2025 22:00
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 10, 2025
Copy link

codecov bot commented Jun 10, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10548 1 10547 9
View the top 1 failed test(s) by shortest run time
EventTraceView renders a trace
Stack Traces | 1.2s run time
Error: Unable to find an element with the text: Trace. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../interfaces/performance/eventTraceView.spec.tsx:110:46)
    at Promise.then.completed (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:121:9)
    at run (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@29.7..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@29.7..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@29.7..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@MichaelSun48 MichaelSun48 merged commit 44c963e into master Jun 11, 2025
50 of 52 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/expandTraceIdColumnHeaderWidth branch June 11, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants