-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
🔧 chore(slack): remove unused metrics #93281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
tags={"type": "update_message"}, | ||
) | ||
_logger.exception("slack.webhook.update_status.response-error") | ||
_logger.info("slack.webhook.update_status.response-error") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add some context/info to help debug the error ?
tags={"type": f"{self.dialog_type}_modal_open"}, | ||
) | ||
_logger.exception( | ||
_logger.info( | ||
"slack.action.response-error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for here and in the other logger.info -
> logger.exception
, would it be helpful to add the exc_info
or report the error to sentry?
we don't have any dashboards or use any of these metrics, so lets remove and save us some 💸 it should be close to 1k in savings
also changed some loggers from exception to info since we don't need the stacktrace or issues for a lot of these issues