Skip to content

feat(ourlogs): Render aggregates table properly, with sorts and pagination #93275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025

Conversation

colin-sentry
Copy link
Member

Implement 'aggregate sort by', 'aggregate group by', aggregate cursor, and log field renderers for functions, and in the aggregate table.

@colin-sentry colin-sentry requested a review from a team as a code owner June 10, 2025 20:32
@colin-sentry colin-sentry requested review from k-fish and removed request for a team June 10, 2025 20:32
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 10, 2025
Copy link

codecov bot commented Jun 12, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10572 1 10571 9
View the top 1 failed test(s) by shortest run time
LogsAggregateTable renders data rows
Stack Traces | 0.095s run time
Error: expect(element).toHaveTextContent()

Expected element to have text content:
  message.template": ".../models/manager/base.py:282: derp
Received:
  .../models/manager/base.py:282: derp
    at .../logs/tables/logsAggregateTable.spec.tsx:138:24
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (.../logs/tables/logsAggregateTable.spec.tsx:136:10)
    at Promise.then.completed (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:121:9)
    at run (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@29.7.0_babel-plugin-macros@3.1..../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@29.7..../jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@29.7..../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@29.7..../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@colin-sentry colin-sentry merged commit 72fd6f8 into master Jun 12, 2025
47 of 49 checks passed
@colin-sentry colin-sentry deleted the ourlogs_aggs_table branch June 12, 2025 20:36
Copy link

sentry-io bot commented Jun 12, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useContext for "LogsPageParamsContext" must be inside a Provider with a value useDefinedContext(utils.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants