feat(snuba): Support start/end filter in get_adjacent_event_ids{,_snql} #93272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-snuba-support-start-end-filter-in-get-adjacent-event-ids-snql
branch
from
bccae51 to
aa74e85
Compare
Part of [RTC-856: Issue Details: the timeline filter should apply to the event paginator](https://linear.app/getsentry/issue/RTC-856/issue-details-the-timeline-filter-should-apply-to-the-event-paginator)
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-snuba-support-start-end-filter-in-get-adjacent-event-ids-snql
branch
from
aa74e85 to
60b8b80
Compare
evanpurkhiser
changed the title
wedamija
approved these changes
Jun 10, 2025
Comment on lines
+497
to
+498
| lower_bound = start or (event.datetime - timedelta(days=100)) | ||
| upper_bound = end or (event.datetime + timedelta(days=100)) |
There was a problem hiding this comment.
we should clamp start and end here just to be safe.
There was a problem hiding this comment.
I think we can let snuba handle this. Will ask around though.
evanpurkhiser
deleted the
evanpurkhiser/feat-snuba-support-start-end-filter-in-get-adjacent-event-ids-snql
branch
vishnupsatish
pushed a commit
that referenced
this pull request
Jun 12, 2025
…l} (#93272) Part of [RTC-856: Issue Details: the timeline filter should apply to the event paginator](https://linear.app/getsentry/issue/RTC-856/issue-details-the-timeline-filter-should-apply-to-the-event-paginator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RTC-856: Issue Details: the timeline filter should apply to the event paginator