Skip to content

fix(dashboards-comparison): Add additional sentry logging comparison script #93266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

nikkikapadia
Copy link
Member

@nikkikapadia nikkikapadia commented Jun 10, 2025

Added some logging for

  • primary error checks (no projects or fields)
  • list of all fields in the widget
  • a trace of the compare function

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 10, 2025
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/discover/compare_tables.py 33.33% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #93266      +/-   ##
==========================================
- Coverage   87.97%   87.96%   -0.02%     
==========================================
  Files       10260    10278      +18     
  Lines      592003   593155    +1152     
  Branches    23003    23003              
==========================================
+ Hits       520823   521751     +928     
- Misses      70690    70914     +224     
  Partials      490      490              

@nikkikapadia nikkikapadia marked this pull request as ready for review June 10, 2025 19:53
@nikkikapadia nikkikapadia requested a review from a team as a code owner June 10, 2025 19:53
@nikkikapadia nikkikapadia merged commit 6fc9be6 into master Jun 12, 2025
62 checks passed
@nikkikapadia nikkikapadia deleted the nikki/fix/dashboards-comparison-add-logs branch June 12, 2025 15:07
vishnupsatish pushed a commit that referenced this pull request Jun 12, 2025
…script (#93266)

Added some logging for 
- primary error checks (no projects or fields)
- list of all fields in the widget
- a trace of the compare function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants