fix(seer-rpc): Enforce seer rpc signature #93253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
aayush-se
reviewed
Jun 10, 2025
Comment on lines
90
to
89
| except Exception: | ||
| logger.exception("Seer RPC signature validation failed") |
There was a problem hiding this comment.
can we throw the exception message in the log if that would be useful?
There was a problem hiding this comment.
logger.exception should log the latest exception to sentry without explicitly passing the exception (and precommit complains if you do lol)
aayush-se
approved these changes
Jun 10, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93253 +/- ##
===========================================
+ Coverage 41.23% 87.97% +46.74%
===========================================
Files 10234 10261 +27
Lines 591108 592037 +929
Branches 23011 23010 -1
===========================================
+ Hits 243757 520867 +277110
+ Misses 346861 70680 -276181
Partials 490 490 |
jennmueng
force-pushed
the
jenn/correct-signature-validation
branch
from
f963512 to
25c324d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming we don't run into any issues, we enforce the signature.