Skip to content

Add total allocated bytes to MemoryInfoContext #93013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leeandher merged 3 commits into from
Jun 23, 2025
Merged

Add total allocated bytes to MemoryInfoContext #93013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2476fe8
Add total allocated bytes to MemoryInfoContext
KnapSac Jun 6, 2025
2b68f29
Fix test
KnapSac Jun 11, 2025
3d04c8b
Fix formatting
KnapSac Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions static/app/components/events/contexts/knownContext/memoryInfo.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const MOCK_MEMORY_INFO_CONTEXT = {
memory_load_bytes: 1048576 * 6,
total_committed_bytes: 1048576 * 7,
promoted_bytes: 1048576 * 8,
total_allocated_bytes: 1048576 * 9,
pinned_objects_count: 150,
pause_time_percentage: 25.5,
index: 12,
Expand Down Expand Up @@ -55,6 +56,7 @@ describe('MemoryInfoContext', function () {
{key: 'memory_load_bytes', subject: 'Memory Load Bytes', value: '6.0 MiB'},
{key: 'total_committed_bytes', subject: 'Total Committed Bytes', value: '7.0 MiB'},
{key: 'promoted_bytes', subject: 'Promoted Bytes', value: '8.0 MiB'},
{key: 'total_allocated_bytes', subject: 'Total Allocated Bytes', value: '9.0 MiB'},
{key: 'pinned_objects_count', subject: 'Pinned Objects Count', value: 150},
{key: 'pause_time_percentage', subject: 'Pause Time Percentage', value: 25.5},
{key: 'index', subject: 'Index', value: 12},
Expand Down
8 changes: 8 additions & 0 deletions static/app/components/events/contexts/knownContext/memoryInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ export function getMemoryInfoContext({
subject: t('Allocated Bytes'),
value: data.allocated_bytes ? formatMemory(data.allocated_bytes) : undefined,
};
case MemoryInfoContextKey.TOTAL_ALLOCATED_BYTES:
return {
key: ctxKey,
subject: t('Total Allocated Bytes'),
value: data.total_allocated_bytes
? formatMemory(data.total_allocated_bytes)
: undefined,
};
case MemoryInfoContextKey.FRAGMENTED_BYTES:
return {
key: ctxKey,
Expand Down
2 changes: 2 additions & 0 deletions static/app/types/event.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ export interface UnityContext {

export enum MemoryInfoContextKey {
ALLOCATED_BYTES = 'allocated_bytes',
TOTAL_ALLOCATED_BYTES = 'total_allocated_bytes',
FRAGMENTED_BYTES = 'fragmented_bytes',
HEAP_SIZE_BYTES = 'heap_size_bytes',
HIGH_MEMORY_LOAD_THRESHOLD_BYTES = 'high_memory_load_threshold_bytes',
Expand Down Expand Up @@ -580,6 +581,7 @@ export interface MemoryInfoContext {
[MemoryInfoContextKey.PAUSE_TIME_PERCENTAGE]?: number;
[MemoryInfoContextKey.INDEX]?: number;
[MemoryInfoContextKey.ALLOCATED_BYTES]?: number;
[MemoryInfoContextKey.TOTAL_ALLOCATED_BYTES]?: number;
[MemoryInfoContextKey.FRAGMENTED_BYTES]?: number;
[MemoryInfoContextKey.HEAP_SIZE_BYTES]?: number;
[MemoryInfoContextKey.HIGH_MEMORY_LOAD_THRESHOLD_BYTES]?: number;
Expand Down
Loading