test: Add test for custom sample rates #93011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## antonpirker/code-changes-for-sdk-3.0.0 #93011 +/- ##
==========================================================================
+ Coverage 81.76% 83.05% +1.29%
==========================================================================
Files 10274 10292 +18
Lines 590216 591697 +1481
Branches 22886 22886
==========================================================================
+ Hits 482568 491428 +8860
+ Misses 106391 99012 -7379
Partials 1257 1257 |
loewenheim
reviewed
Jun 6, 2025
tests/sentry/ingest/ingest_consumer/test_ingest_consumer_processing.py
Outdated
Show resolved
Hide resolved
szokeasaurusrex
force-pushed
the
szokeasaurusrex/custom-sample-rate-test
branch
from
4cd03ce to
7605898
Compare
loewenheim
approved these changes
Jun 11, 2025
|
|
||
| with patch.dict(os.environ, env_dict, clear=True): | ||
| with django.test.override_settings(SENTRY_INGEST_CONSUMER_APM_SAMPLING=settings_value): | ||
| # If settings_value is None, delete the setting to simulate it not being set |
There was a problem hiding this comment.
override_settings doesn't do this automatically? That's a shame.
There was a problem hiding this comment.
No, it sets it to None
antonpirker
merged commit 443f074
into
antonpirker/code-changes-for-sdk-3.0.0
57 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.