Remove usage of measurements in favor of span.data.
#92718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92718 +/- ##
===========================================
+ Coverage 65.20% 87.97% +22.76%
===========================================
Files 10285 10267 -18
Lines 590580 589612 -968
Branches 22965 22732 -233
===========================================
+ Hits 385088 518694 +133606
+ Misses 205045 70473 -134572
+ Partials 447 445 -2 |
antonpirker
changed the title
measurments in favor of span.data.measurements in favor of span.data.
wmak
approved these changes
Jun 5, 2025
sl0thentr0py
approved these changes
Jun 5, 2025
…getsentry/sentry into antonpirker/remove-measurements
shellmayr
pushed a commit
that referenced
this pull request
Jun 12, 2025
Python SDK 3.0 removes measurements. This PR makes sure that we do not use `measurements` internally but rather use `span.data` instead. --------- Co-authored-by: Daniel Szoke <daniel.szoke@sentry.io>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Python SDK 3.0 removes measurements. This PR makes sure that we do not use `measurements` internally but rather use `span.data` instead. --------- Co-authored-by: Daniel Szoke <daniel.szoke@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next major version of Python SDK 3.0 will remove measurements. This PR makes sure that we do not use
measurementsinternally but rather usespan.datainstead.This is part of a bigger change tracked here: #92011