-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(grouping): Cache enhancements in split form #92000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
yuvmen
approved these changes
May 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Right now, even when we're using split enhancements, the version we cache isn't split, which means that every time we pull them out of the cache, the work to split the rules has to be done all over again. This is obviously not ideal, so this PR changes the way we compute (and parse) the cached string so that it now includes the split rules. Since the rust enhancer can only parse base64 strings including one set of rules, this is done by computing a separate string for each of the three kinds of rules - rules in their original/pre-split form, classifier rules, and contributes rules - and then concatenating them, separated by a character which can't ever appear in base64. Older base64 strings containing only the original rules and no delimiter can still be parsed, because for them, splitting on the delimiter will be a no-op.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, even when we're using split enhancements, the version we cache isn't split, which means that every time we pull them out of the cache, the work to split the rules has to be done all over again. This is obviously not ideal, so this PR changes the way we compute (and parse) the cached string so that it now includes the split rules.
Since the rust enhancer can only parse base64 strings including one set of rules, this is done by computing a separate string for each of the three kinds of rules - rules in their original/pre-split form, classifier rules, and contributes rules - and then concatenating them, separated by a character which can't ever appear in base64. Older base64 strings containing only the original rules and no delimiter can still be parsed, because for them, splitting on the delimiter will be a no-op.