Skip to content

fix(aci): add detectorIds to Workflow serializer #91998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

ameliahsu
Copy link
Member

we need to know what detectors are connected to a workflow for the UI

@ameliahsu ameliahsu requested a review from a team as a code owner May 20, 2025 23:23
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157341 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #91998       +/-   ##
===========================================
+ Coverage   36.78%   87.63%   +50.84%     
===========================================
  Files        9662    10359      +697     
  Lines      540758   587562    +46804     
  Branches    22604    22604               
===========================================
+ Hits       198930   514886   +315956     
+ Misses     341407    72255   -269152     
  Partials      421      421               

Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks for all the cleanup on this!

--

Just curious, should we split the serializers file up and have these serializers broken down into multiple files?

@ameliahsu
Copy link
Member Author

@saponifi3d definitely something to consider, i know the action handler serializer is pretty chunky 😅

@ameliahsu ameliahsu merged commit efb924d into master May 21, 2025
60 checks passed
@ameliahsu ameliahsu deleted the mia/aci/detector-workflow-ids branch May 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants