feat(ACI): Use status column on Detector and Workflow #91994
+118
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
ceorourke
commented
May 21, 2025
| @@ -107,6 +108,7 @@ def delete(self, request: Request, organization: Organization, workflow: Workflo | |||
| Delete a workflow | |||
| """ | |||
| RegionScheduledDeletion.schedule(workflow, days=0, actor=request.user) | |||
| workflow.update(status=ObjectStatus.PENDING_DELETION) | |||
There was a problem hiding this comment.
Setting it to pending deletion in the delete endpoint after it's been scheduled for deletion
ceorourke
commented
May 21, 2025
| @@ -169,6 +172,7 @@ def delete(self, request: Request, organization: Organization, detector: Detecto | |||
| return Response(status=403) | |||
|
|
|||
| RegionScheduledDeletion.schedule(detector, days=0, actor=request.user) | |||
| detector.update(status=ObjectStatus.PENDING_DELETION) | |||
There was a problem hiding this comment.
Setting it to pending deletion in the delete endpoint after it's been scheduled for deletion
ceorourke
commented
May 21, 2025
| for instance in instance_list: | ||
| status = getattr(instance, "status", None) | ||
| if status not in (ObjectStatus.DELETION_IN_PROGRESS, None): | ||
| instance.update(status=ObjectStatus.DELETION_IN_PROGRESS) |
There was a problem hiding this comment.
Setting it to deletion in progress
ceorourke
commented
May 21, 2025
| for instance in instance_list: | ||
| status = getattr(instance, "status", None) | ||
| if status not in (ObjectStatus.DELETION_IN_PROGRESS, None): | ||
| instance.update(status=ObjectStatus.DELETION_IN_PROGRESS) |
There was a problem hiding this comment.
Setting it to deletion in progress
|
I know it's a lot of files touched but it's the same change across most except those that I called out in the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
DetectorandWorkflowmodels have astatuscolumn we can make use of it. This PR sets the status toPENDING_DELETIONin the deletion endpoints, sets the status toDELETION_IN_PROGRESSin the deletion tasks, and updates all gets and filters to filter toACTIVEstatuses.