Skip to content

ref: handle AnonymousUser in some views #91884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

asottile-sentry
Copy link
Member

this is needed to upgrade django-stubs. I think in every place here these are superfluous but are helpful to teach the type checker what is going on

@asottile-sentry asottile-sentry requested review from a team as code owners May 19, 2025 18:32
@asottile-sentry asottile-sentry requested review from Lms24 and chargome and removed request for a team May 19, 2025 18:32
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 53.57143% with 39 lines in your changes missing coverage. Please review.

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157237 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Files with missing lines Patch % Lines
src/sentry/relocation/api/endpoints/index.py 57.14% 3 Missing ⚠️
...rc/sentry/api/endpoints/accept_project_transfer.py 66.66% 2 Missing ⚠️
src/sentry/api/endpoints/api_authorizations.py 50.00% 2 Missing ⚠️
src/sentry/api/endpoints/assistant.py 50.00% 2 Missing ⚠️
src/sentry/api/endpoints/broadcast_index.py 60.00% 2 Missing ⚠️
...ntry/api/endpoints/organization_pinned_searches.py 50.00% 2 Missing ⚠️
...rc/sentry/api/endpoints/trace_explorer_ai_query.py 0.00% 2 Missing ⚠️
...rc/sentry/api/endpoints/trace_explorer_ai_setup.py 0.00% 2 Missing ⚠️
.../sentry/explore/endpoints/explore_saved_queries.py 50.00% 2 Missing ⚠️
...ssues/endpoints/organization_group_search_views.py 50.00% 2 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91884      +/-   ##
==========================================
- Coverage   87.62%   87.62%   -0.01%     
==========================================
  Files       10357    10355       -2     
  Lines      586880   586956      +76     
  Branches    22585    22585              
==========================================
+ Hits       514250   514291      +41     
- Misses      72202    72237      +35     
  Partials      428      428              

@asottile-sentry asottile-sentry merged commit cb103d0 into master May 20, 2025
60 checks passed
@asottile-sentry asottile-sentry deleted the asottile-handle-anon-users branch May 20, 2025 14:28
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
this is needed to upgrade django-stubs. I think in every place here
these are superfluous but are helpful to teach the type checker what is
going on

<!-- Describe your PR here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants