Skip to content

WIP feat(code_mapping): Support single file #91147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP feat(code_mapping): Support single file #91147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/issues/auto_source_code_config/code_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def __init__(self, frame: Mapping[str, Any], platform: str | None = None) -> Non
not frame_file_path
or frame_file_path[0] in ["[", "<"]
or frame_file_path.find(" ") > -1
or frame_file_path.find("/") == -1
or not frame_file_path[0].isalpha()
):
raise UnsupportedFrameInfo("This path is not supported.")

Expand Down
6 changes: 1 addition & 5 deletions tests/sentry/issues/auto_source_code_config/test_code_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,12 @@
]
UNSUPPORTED_FRAME_FILENAMES = [
"async https://s1.sentry-cdn.com/_static/dist/sentry/entrypoints/app.js",
"/gtm.js", # Top source; starts with backslash
"<anonymous>",
"<frozen importlib._bootstrap>",
"[native code]",
"O$t",
"async https://s1.sentry-cdn.com/_static/dist/sentry/entrypoints/app.js",
"README", # top level file
"ssl.py",
# XXX: The following will need to be supported
"initialization.dart",
"backburner.js",
]
NO_EXTENSION_FRAME_FILENAMES = [
"/foo/bar/baz", # no extension
Expand Down Expand Up @@ -108,6 +103,7 @@ def test_buckets_logic() -> None:
"app:": [FrameInfo({"filename": "app://foo.js"})],
"cronscripts": [FrameInfo({"filename": "/cronscripts/monitoringsync.php"})],
"getsentry": [FrameInfo({"filename": "getsentry/billing/tax/manager.py"})],
"gtm.js": [FrameInfo({"filename": "/gtm.js"})],
}


Expand Down
Loading