fix(product-selection): Fix tests and remove skips #86463
Closed
+29
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
Mar 6, 2025
| @@ -228,37 +223,7 @@ describe('Onboarding Product Selection', function () { | |||
| expect(screen.getByRole('checkbox', {name: 'Session Replay'})).toBeDisabled(); | |||
| }); | |||
|
|
|||
| // TODO: This test does not play well with deselected products by default | |||
| // eslint-disable-next-line jest/no-disabled-tests | |||
| it.skip('selects all products per default', async function () { | |||
There was a problem hiding this comment.
we already have a similar test, 'applies defined default product selection,' so this test can be removed
|
Converted this PR to a draft as I want to investigate if we can remove the part where we strip the URL. If yes, then what we are testing in the |
|
closing this in favour of #86582 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.