Skip to content

fix(api): Clean up API grants when revoking authorizations #85571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Feb 20, 2025

Pulled from #82052 to break out these changes into smaller PRs.

  • Delete associated grant when revoking API authorizations
  • Use proper transaction management with outbox_context

@mdtro mdtro requested a review from sentaur-athena February 20, 2025 19:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 20, 2025
@mdtro mdtro marked this pull request as ready for review February 20, 2025 19:40
@mdtro mdtro requested a review from a team February 20, 2025 19:41
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #85571       +/-   ##
===========================================
+ Coverage   42.21%   87.89%   +45.67%     
===========================================
  Files        9655     9685       +30     
  Lines      547539   549125     +1586     
  Branches    21312    21312               
===========================================
+ Hits       231160   482638   +251478     
+ Misses     316063    66171   -249892     
  Partials      316      316               

- Delete associated grant when revoking API authorizations
- Use proper transaction management with outbox_context
@mdtro mdtro force-pushed the mdtro/api-auth-cleanup branch from c0eff0a to 6206b47 Compare February 25, 2025 16:09
@mdtro mdtro merged commit 12403cc into master Feb 26, 2025
49 checks passed
@mdtro mdtro deleted the mdtro/api-auth-cleanup branch February 26, 2025 15:42
ameliahsu pushed a commit that referenced this pull request Mar 5, 2025
Pulled from #82052 to break out
these changes into smaller PRs.

- Delete associated grant when revoking API authorizations
- Use proper transaction management with outbox_context
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants