-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore(profiling): Update python profiling docs for new SDK #85560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): Update python profiling docs for new SDK #85560
Conversation
This uses the updated python sdk where - `start_profiler` is replaced by `start_profile_session` - `stop_profiler` is replaced by `stop_profiler_session` - `_experiments["continuous_profiling_auto_start"]` is replaced by `profile_lifecycle` - this differs slightly to only profile traces instead of all the time
Need to wait until getsentry/sentry-python#4079 is in a release |
Rename to profile_session_sample_rate introduced in https://github.com/getsentry/sentry-python/pull/4002/files
❌ 28 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my inline comment.
Also, our Docs page says continuous profiling is still in Beta. Is this accurate? If yes, maybe we should wait until this is out of beta to merge this change; otherwise, let's remove the Beta notice from the Docs page.
instead of start_profile_session and stop_profile_session
This uses the updated python sdk where
_experiments["continuous_profiling_auto_start"]
is replaced byprofile_lifecycle