feat(crons): Implement an all checks page for crons#85202
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 44.69kB (0.14%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
Files in
Files in
Files in
Files in
Files in
Files in
|
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| @@ -0,0 +1,23 @@ | |||
| import {CheckInStatus, CheckIn, ScheduleType} from 'sentry/views/monitors/types'; | |||
|
|
|||
| export function CheckInFixture(params: Partial<CheckIn> = {}): CheckIn { | |||
Member
There was a problem hiding this comment.
Do we really not have this already 😱
Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com>
Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com>
Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com>
evanpurkhiser
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an all monitor checks page for cron issues with some custom cells. There is one thing that should be addressed though but it requires a backend fix, the schedule from the API currently returns the enum integer for the schedule (e.g.
1instead ofcrontab). I will put up a PR to fix this serialization, since without it, the number appears in the tool tip, along with 'Unknown Schedule'.todo