Skip to content

ref(uptime): Remove config_topic from UptimeRegionConfig #85155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

ref(uptime): Remove config_topic from UptimeRegionConfig #85155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/sentry/conf/types/uptime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import dataclasses

from sentry.conf.types.kafka_definition import Topic


@dataclasses.dataclass
class UptimeRegionConfig:
Expand All @@ -13,8 +11,6 @@ class UptimeRegionConfig:
name: str
# TODO: Remove once no region configurations are setting this
enabled: bool = True
# TODO: Remove once we've removed config that relies on this
config_topic: Topic | None = None
# Temporarily defaulted for backwards compat
config_redis_cluster: str = "default"
# Prefix we'll add to keys in the redis config. Currently just used in tests
Expand Down
Loading