🔧 chore(aci): Add support to invoke rule registry email handler from NOA #85130
+245
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrajjoshi
commented
Feb 13, 2025
| @@ -87,7 +96,6 @@ class ActionFieldMapping(TypedDict): | |||
| Action.Type.GITHUB: ActionFieldMapping( | |||
| id="sentry.integrations.github.notify_action.GitHubCreateTicketAction", | |||
| integration_id_key="integration", | |||
| target_identifier_key="repo", | |||
There was a problem hiding this comment.
mistake found with test updates
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
commented
Feb 13, 2025
| } | ||
|
|
||
|
|
||
| class TestGithubIssueAlertHandler(TestTicketingIssueAlertHandlerBase): | ||
| def test_build_rule_action_blob(self): | ||
| for expected in GITHUB_ACTION_DATA_BLOBS: | ||
| self._test_build_rule_action_blob(expected, Action.Type.GITHUB) | ||
| if expected["id"] == ACTION_FIELD_MAPPINGS[Action.Type.GITHUB]["id"]: |
There was a problem hiding this comment.
something else found with test updates. we have to do this since github/github enterprise config looks identical (based on code, currently there are no prod actions set up for ghe).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support to send emails for issue alerts via NOA.
as part of this change, i also decomposed some of the translation for email so it can be reused between migration and noa.
i also fixed up some tests for Ticketing since i realized the comparison i was doing was incorrect (i was comparing the result with itself)