Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(grouping): Add sample rate for grouphash metadata backfill #85127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Feb 13, 2025

This adds a new option, grouping.grouphash_metadata.backfill_sample_rate, to control the rate at which we add or update grouphash metadata for existing grouphashes. It also adds and switches to using a helper function, should_handle_grouphash_metadata, which checks both the existing killswitch and feature flag and the new option in cases where the grouphash already exists.

There's not yet any code to do the adding/updating (and the option defaults to 0), so this doesn't change any behavior*, but it does set us up for when said code is added.

*This is only 99.9% true. Technically there is a theoretical behavior change, in that the one bit of updating we already do (to the grouping config) is now subject to the sample rate, which is currently 0. That said, we've been on the same grouping config since we started collecting grouphash metadata, so there aren't any records to update. So a thing that never happens now actually can't happen (at least until we up the sample rate), but in the real world that doesn't actually make things any different.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 13, 2025
@lobsterkatie lobsterkatie marked this pull request as ready for review February 13, 2025 01:40
@lobsterkatie lobsterkatie requested a review from a team as a code owner February 13, 2025 01:40
@lobsterkatie lobsterkatie force-pushed the kmclb-add-grouphash-metadata-backfill-sample-rate branch from 5758a3c to 6671d6c Compare February 13, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants