Skip to content

feat(explore): Add is_transaction to explore fields #83423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat(explore): Add is_transaction to explore fields #83423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions static/app/utils/fields/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,6 +1155,7 @@ export const SPAN_OP_FIELDS: Record<SpanOpBreakdown, FieldDefinition> = {
};

type TraceFields =
| SpanIndexedField.IS_TRANSACTION
| SpanIndexedField.SPAN_ACTION
| SpanIndexedField.SPAN_DESCRIPTION
| SpanIndexedField.SPAN_DOMAIN
Expand Down Expand Up @@ -1225,6 +1226,11 @@ export const TRACE_FIELD_DEFINITIONS: Record<TraceFields, FieldDefinition> = {
kind: FieldKind.FIELD,
valueType: FieldValueType.STRING,
},
[SpanIndexedField.IS_TRANSACTION]: {
desc: t('The span is also a transaction'),
kind: FieldKind.FIELD,
valueType: FieldValueType.BOOLEAN,
},
};

type AllEventFieldKeys =
Expand Down
1 change: 1 addition & 0 deletions static/app/views/explore/contexts/spanTagsContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export function SpanTagsProvider({children, dataset, enabled}: SpanTagsProviderP
SpanIndexedField.USER_ID,
SpanIndexedField.USER_IP,
SpanIndexedField.USER_USERNAME,
SpanIndexedField.IS_TRANSACTION, // boolean field but we can expose it as a string
].map(tag => [
tag,
{
Expand Down
1 change: 1 addition & 0 deletions static/app/views/insights/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ export enum SpanIndexedField {
MESSAGING_MESSAGE_RETRY_COUNT = 'measurements.messaging.message.retry.count',
MESSAGING_MESSAGE_DESTINATION_NAME = 'messaging.destination.name',
USER_GEO_SUBREGION = 'user.geo.subregion',
IS_TRANSACTION = 'is_transaction',
}

export type SpanIndexedResponse = {
Expand Down
Loading