ref: Ladder class
#83259
Draft
ref: Ladder class
#83259
+155
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
static/app/utils/number/ladder.tsx
Outdated
| type Rung<T> = [threshold: number, value: T]; | ||
|
|
||
| /** | ||
| * Class that represents a value ladder. Given a ladder of increasing thresholds, the ladder can match an incoming value against the known intervals. |
There was a problem hiding this comment.
Any chance we could add some examples and maybe an example use case?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83259 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 9470 9470
Lines 537279 537269 -10
Branches 21151 21150 -1
=======================================
- Hits 470373 470365 -8
+ Misses 66548 66547 -1
+ Partials 358 357 -1 |
Bundle ReportChanges will increase total bundle size by 33.87kB (0.11%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting a
Ladderclass out ofGranularityLadder. The mechanism of matching values against increasing intervals is really common at Sentry, I want to use this in more places.My immediate need is duration formatting. We have code all over the place that takes a count of milliseconds and then decides whether it should be converted to seconds, minutes, years, etc. by checking this exactly kind of ladder logic.