Skip to content

feat(trace-view): Info panel tab for new users - #82408

Closed
0Calories wants to merge 12 commits into
masterfrom
ash/feat/trace-view-intro-panel
Closed

0Calories wants to merge 12 commits into
masterfrom
ash/feat/trace-view-intro-panel

Conversation

@0Calories

Copy link
Copy Markdown
Contributor

No description provided.

@0Calories 0Calories self-assigned this Dec 19, 2024
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 19, 2024
@codecov

codecov Bot commented Dec 19, 2024 •

Copy link
Copy Markdown

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
5195 5 5190 0
View the top 3 failed tests by shortest run time
trace view tabbing clicking on a node spawns a new tab when none is selected
Stack Traces | 0.465s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [<li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><button class="css-1js4d2s-TabButton e1diyy3e5">Trace</button></li>, <li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><svg fill="currentColor" height="12px" style="margin-right: 2px;" viewBox="0 0 16 16" width="12px"><path d="M8,11.78A.74.74,0,0,1,7.24,11V7a.75.75,0,0,1,1.5,0v4A.75.75,0,0,1,8,11.78Z" /><circle cx="8" cy="4.78" r="0.76" /><path d="M8,16a8,8,0,1,1,8-8A8,8,0,0,1,8,16ZM8,1.53A6.47,6.47,0,1,0,14.47,8,6.47,6.47,0,0,0,8,1.53Z" /></svg><button class="css-1js4d2s-TabButton e1diyy3e5">Help</button></li>]
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1532:81)
trace view tabbing clicking a node that is already open in a tab switches to that tab and persists the previous node
Stack Traces | 0.468s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [<li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><button class="css-1js4d2s-TabButton e1diyy3e5">Trace</button></li>, <li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><svg fill="currentColor" height="12px" style="margin-right: 2px;" viewBox="0 0 16 16" width="12px"><path d="M8,11.78A.74.74,0,0,1,7.24,11V7a.75.75,0,0,1,1.5,0v4A.75.75,0,0,1,8,11.78Z" /><circle cx="8" cy="4.78" r="0.76" /><path d="M8,16a8,8,0,1,1,8-8A8,8,0,0,1,8,16ZM8,1.53A6.47,6.47,0,1,0,14.47,8,6.47,6.47,0,0,0,8,1.53Z" /></svg><button class="css-1js4d2s-TabButton e1diyy3e5">Help</button></li>]
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1600:81)
trace view tabbing clicking on a node replaces the previously selected tab
Stack Traces | 0.508s run time
Error: expect(received).toHaveLength(expected)

Expected length: 1
Received length: 2
Received array:  [<li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><button class="css-1js4d2s-TabButton e1diyy3e5">Trace</button></li>, <li aria-selected="false" class="Static css-1su9mu6-Tab e1diyy3e7" data-test-id="trace-drawer-tab"><svg fill="currentColor" height="12px" style="margin-right: 2px;" viewBox="0 0 16 16" width="12px"><path d="M8,11.78A.74.74,0,0,1,7.24,11V7a.75.75,0,0,1,1.5,0v4A.75.75,0,0,1,8,11.78Z" /><circle cx="8" cy="4.78" r="0.76" /><path d="M8,16a8,8,0,1,1,8-8A8,8,0,0,1,8,16ZM8,1.53A6.47,6.47,0,1,0,14.47,8,6.47,6.47,0,0,0,8,1.53Z" /></svg><button class="css-1js4d2s-TabButton e1diyy3e5">Help</button></li>]
    at Object.<anonymous> (.../performance/newTraceDetails/trace.spec.tsx:1543:81)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@getsantry

getsantry Bot commented Jan 10, 2025

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Jan 10, 2025
@0Calories 0Calories added WIP and removed Stale labels Jan 10, 2025
@natemoo-re

Copy link
Copy Markdown
Member

Hey! We are cleaning up our PR backlog to cut down on noise. Since this draft was created more than 6 months ago and doesn't have much recent activity, I'm closing it.

If you’re still interested in seeing this land, please feel free to reopen.

@natemoo-re natemoo-re closed this Jul 25, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2025

This branch was successfully deployed

1 active deployment
Preview — 1f86dfb8 Deployed Dec 19, 2024 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants