DLQ testing with options feature flag #82283
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/ingest/consumer/processors.py
Did you find this useful? React with a 👍 or 👎 |
github-actions
bot
added
the
Scope: Backend
| consumer_type == ConsumerType.Transactions or data.get("type") == "transaction" | ||
| ) and options.get("transactions.stale_dlq_enabled"): | ||
| # check timestamp | ||
| timestamp = message.get("timestamp") if message.get("timestamp") else start_time |
There was a problem hiding this comment.
not sure if message.get('timesstamp") works need to double check
There was a problem hiding this comment.
i think it'll be data.get("timestamp") instead
There was a problem hiding this comment.
i found in the schema repo that "timestamp" field is on the same level as "type". And in this file the field type is being accesed like data.get("type")
| # check timestamp | ||
| timestamp = message.get("timestamp") if message.get("timestamp") else start_time | ||
|
|
||
| if timestamp and datetime.datetime.now() - timestamp > options.get( |
There was a problem hiding this comment.
these times probably need to be normalized
There was a problem hiding this comment.
what do you mean normalized?
| raise InvalidMessage( | ||
| message.get("partition"), | ||
| message.get("offset"), | ||
| reason="Stale Message", |
There was a problem hiding this comment.
let's not do a space? idk spaces usually scare me in strings
| consumer_type == ConsumerType.Transactions or data.get("type") == "transaction" | ||
| ) and options.get("transactions.stale_dlq_enabled"): | ||
| # check timestamp | ||
| timestamp = message.get("timestamp") if message.get("timestamp") else start_time |
There was a problem hiding this comment.
i think it'll be data.get("timestamp") instead
| consumer_type == ConsumerType.Transactions or data.get("type") == "transaction" | ||
| ) and options.get("transactions.stale_dlq_enabled"): | ||
| # check timestamp | ||
| timestamp = message.get("timestamp") if message.get("timestamp") else start_time |
There was a problem hiding this comment.
i found in the schema repo that "timestamp" field is on the same level as "type". And in this file the field type is being accesed like data.get("type")
|
closing because #82322 |
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.