Skip to content

ref: fix types for test_event_attachment_details #82091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

ref: fix types for test_event_attachment_details #82091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,6 @@ module = [
"tests.sentry.api.bases.test_team",
"tests.sentry.api.endpoints.notifications.test_notification_actions_details",
"tests.sentry.api.endpoints.notifications.test_notification_actions_index",
"tests.sentry.api.endpoints.test_event_attachment_details",
"tests.sentry.api.helpers.test_group_index",
"tests.sentry.api.test_authentication",
"tests.sentry.api.test_base",
Expand Down
5 changes: 3 additions & 2 deletions tests/sentry/api/endpoints/test_event_attachment_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from sentry.attachments.base import CachedAttachment
from sentry.models.activity import Activity
from sentry.models.eventattachment import EventAttachment
from sentry.testutils.cases import APITestCase, PermissionTestCase
from sentry.testutils.cases import APITestCase, PermissionTestCase, TestCase
from sentry.testutils.helpers.datetime import before_now
from sentry.testutils.helpers.features import with_feature
from sentry.testutils.helpers.options import override_options
Expand All @@ -17,7 +17,7 @@
ATTACHMENT_CONTENT = b"File contents here" * 10_000


class CreateAttachmentMixin:
class CreateAttachmentMixin(TestCase):
def create_attachment(self, content: bytes | None = None, group_id: int | None = None):
self.project = self.create_project()
self.release = self.create_release(self.project, self.user)
Expand Down Expand Up @@ -151,6 +151,7 @@ def test_delete_activity_with_group(self):
delete_activity = Activity.objects.get(type=ActivityType.DELETED_ATTACHMENT.value)
assert delete_activity.project == self.project
assert delete_activity.group_id == group_id
assert delete_activity.group is not None
assert delete_activity.group.id == group_id


Expand Down
Loading