fix(insights): all projects selected shows no data insight modules in superuser mode #82041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
edwardgou-sentry
approved these changes
Dec 12, 2024
| @@ -52,6 +53,9 @@ export function useHasFirstSpan(module: ModuleName, projects?: Project[]): boole | |||
| // - [] empty list represents "My Projects" | |||
| // - [-1] represents "All Projects" | |||
| // - [.., ..] otherwise, represents a list of project IDs | |||
| if (pageFilters.selection.projects.length === 0 && isActiveSuperuser()) { | |||
| selectedProjects = allProjects; // when superuser is enabled, My Projects isn't applicable, and in reality all projects are selected when projects.length === 0 | |||
| } | |||
| if (pageFilters.selection.projects.length === 0) { | |||
| selectedProjects = allProjects.filter(p => p.isMember); | |||
There was a problem hiding this comment.
Suggested change
| selectedProjects = allProjects.filter(p => p.isMember); | |
| selectedProjects = allProjects.filter(p => p.isMember || isActiveSuperuser()); |
same thing but shorter, maybe less obvious what it does though 🤷
There was a problem hiding this comment.
Yeah, that's a good call out, thanks! I accidentally merged this, but I can make this change
There was a problem hiding this comment.
At first I thought it wasn't obvious, but it makes sense actually as they are both conditions on the user (isMemeber or isSuperusuer).
It is an unnecessary filter, but the performance of that is negligible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #82035
Basically, in superuser, sometimes
pageFilters.selection.projectsreturns[]when all projects are selected. However the code assumes empty array is "my projects".