feat(dashboards): Add AreaChartWidget
#81962
Conversation
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 20.61kB (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
This all looks good to me, it's clear what the area chart is doing!
I only raised a product concern about mismatching types. fwiw explore allows you to turn on an area chart and they don't stack, which makes mismatched types more sensical? I think it's probably a result of moving fast and not exactly intended though. We should check if there's a valid use case for mismatched type area charts. For lines, plotting something like throughput and latency make sense, but I also think we should support multiple y-axis sometime. i.e. this is all good, it just raised some thoughts about how area charts are supposed to work
| // show an error. | ||
| const firstSeries = props.timeseries[0]; | ||
|
|
||
| // TODO: Raise error if attempting to plot series of different types or units |
There was a problem hiding this comment.
Not that I disagree, but line charts could conceivably plot different types so this is where some behaviour would diverge. Is this restriction intended to satisfy the "area charts show parts of a whole" detail? We'll have to consider how this is handled with the widget builder because I don't think this restriction exists there yet.
There was a problem hiding this comment.
🤔 is it possible in the Widget Builder to query mismatched data? If yes, how does that work, what does the Y Axis do? If I plot, say, duration and error rate
static/app/views/dashboards/widgets/areaChartWidget/areaChartWidgetVisualization.tsx
Show resolved
Hide resolved
Adds an `AreaChartWidget`. Just like `LineChartWidget` but doesn't support as many features for now! This creates a whole bunch of code duplication that I'll resolve over time. Closes #81836
Adds an
AreaChartWidget. Just likeLineChartWidgetbut doesn't support as many features for now! This creates a whole bunch of code duplication that I'll resolve over time.Closes #81836
e.g.,
