Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(insights): group all module routes under one constant #81465

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Nov 29, 2024

This PR groups all module routes under one moduleRoutes constant. And then this constant is used within the frontend,backend,mobile and ai domain view routes. There's two motivations behind this

  1. Simplifies adding new modules, you only have to add routes in one place
  2. We have had a couple internal and external feedback, that certain modules belong in certain domains. For example some users requested http module should be under mobile as well. And we may add the assets module to mobile at some point too. This PR means we never have to worry about adding new routes when moving modules to new domains, we just have to update the header tabs to link to the module.

One drawback is that there will be some unused routes, but I don't see this being a problem, and it simplifies things a little.

@DominikB2014 DominikB2014 requested review from a team November 29, 2024 17:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 29, 2024
@DominikB2014 DominikB2014 merged commit 122f4be into master Dec 3, 2024
46 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/group-all-modules branch December 3, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants