Allow promoting a user to admin via the manage users page. #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes (such as if you're using ldap for authentication), the primary admin of the install won't be that of the initial superuser. Using the initial superuser, you should be able to promote any other user to be an admin - via the is_staff flag. This patch allows this promotion, by extending the ChangeUserForm, currently used to administratively modify users.
|
One note here is that is_staff wont actually let them do anything other than view the admin. Is that enough? |
|
As far as I can tell /admin/ uses is_admin, which just wraps is_staff... since django admin etc aren't accessible I can't see a need for is_superuser. Possible the wording is slightly misleading as 'administrative' could be mean more superuser level, however for user friendliness I think wrapping limited stuff under /admin/ is preferable and works just nicely. |
|
Forgot about those pages ;) |
dcramer
added a commit
that referenced
this pull request
Mar 3, 2013
Allow promoting a user to admin via the manage users page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (such as if you're using ldap for authentication), the primary admin of the install won't be that of the initial superuser.
Using the initial superuser, you should be able to promote any other user to be an admin - via the is_staff flag.
This patch allows this promotion, by extending the ChangeUserForm, currently used to administratively modify users.