Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(contexts): Use newly added computed contexts #80579

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ref(contexts): Use newly added computed contexts #80579

wants to merge 1 commit into from

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Nov 12, 2024 •
edited
Loading

This PR uses the new computed contexts fields that were added in Relay in getsentry/relay#4239.

Needs: getsentry/relay#4239

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 12, 2024
@iambriccardo iambriccardo added the Do Not Merge Don't merge label Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
23011 8 23003 214
View the top 3 failed tests by shortest run time 
tests.sentry.event_manager.interfaces.test_contexts::test_runtime_normalization
Stack Traces | 0.051s run time 
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:51: in test_runtime_normalization
    make_ctx_snapshot(
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:15: in inner
    insta_snapshot(
#x1B[1m#x1B[31mE   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m
#x1B[1m#x1B[31mE   Snapshot .../snapshots/test_contexts/test_runtime_normalization.pysnap changed!#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -1,7 +1,5 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE    errors: null#x1B[0m
#x1B[1m#x1B[31mE    tags:#x1B[0m
#x1B[1m#x1B[31mE   -- - runtime#x1B[0m
#x1B[1m#x1B[31mE   -  - .NET Framework 4.7.2#x1B[0m
#x1B[1m#x1B[31mE    - - runtime.name#x1B[0m
#x1B[1m#x1B[31mE      - .NET Framework#x1B[0m
#x1B[1m#x1B[31mE    to_json:#x1B[0m
#x1B[1m#x1B[31mE   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m

tests.sentry.event_manager.interfaces.test_contexts::test_os_normalization
Stack Traces | 0.052s run time 
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:43: in test_os_normalization
    make_ctx_snapshot({"os": {"raw_description": "Microsoft Windows 6.1.7601 S"}})
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:15: in inner
    insta_snapshot(
#x1B[1m#x1B[31mE   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m
#x1B[1m#x1B[31mE   Snapshot .../snapshots/test_contexts/test_os_normalization.pysnap changed!#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -1,7 +1,5 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE    errors: null#x1B[0m
#x1B[1m#x1B[31mE    tags:#x1B[0m
#x1B[1m#x1B[31mE   -- - os#x1B[0m
#x1B[1m#x1B[31mE   -  - Windows 7#x1B[0m
#x1B[1m#x1B[31mE    - - os.name#x1B[0m
#x1B[1m#x1B[31mE      - Windows#x1B[0m
#x1B[1m#x1B[31mE    to_json:#x1B[0m
#x1B[1m#x1B[31mE   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m

tests.sentry.event_manager.interfaces.test_contexts::test_runtime
Stack Traces | 0.053s run time 
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:47: in test_runtime
    make_ctx_snapshot({"runtime": {"name": "Java", "version": "1.2.3", "build": "BLAH"}})
#x1B[1m#x1B[.../event_manager/interfaces/test_contexts.py#x1B[0m:15: in inner
    insta_snapshot(
#x1B[1m#x1B[31mE   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m
#x1B[1m#x1B[31mE   Snapshot .../snapshots/test_contexts/test_runtime.pysnap changed!#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -1,7 +1,5 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE    errors: null#x1B[0m
#x1B[1m#x1B[31mE    tags:#x1B[0m
#x1B[1m#x1B[31mE   -- - runtime#x1B[0m
#x1B[1m#x1B[31mE   -  - Java 1.2.3#x1B[0m
#x1B[1m#x1B[31mE    - - runtime.name#x1B[0m
#x1B[1m#x1B[31mE      - Java#x1B[0m
#x1B[1m#x1B[31mE    to_json:#x1B[0m
#x1B[1m#x1B[31mE   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iambriccardo