Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue summary + issue-details): Move resources section to sidebar #80507

Closed
wants to merge 1 commit into from

Conversation

roaga
Copy link
Member

@roaga roaga commented Nov 8, 2024

Building toward the new design for the Solution Center / Issue Summary / Autofix, this PR moves the traditional Resources section into its own part of the streamlined sidebar instead of being inside the Solutions Center. The Solutions Center is only shown when the Issue Summary is available (in a future PR, this will become the Sentry AI drawer).

Screenshot 2024-11-08 at 3 38 35 PM

@roaga roaga requested a review from a team as a code owner November 8, 2024 23:44
@roaga roaga requested a review from jennmueng November 8, 2024 23:44
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 8, 2024
@roaga roaga changed the title chore(issue summary): Move resources section to sidebar chore(issue summary + issue-details): Move resources section to sidebar Nov 8, 2024
@roaga roaga changed the title chore(issue summary + issue-details): Move resources section to sidebar feat(issue summary + issue-details): Move resources section to sidebar Nov 8, 2024
@roggenkemper
Copy link
Member

I think the team has some concerns with moving resources into its own section in the sidebar - probably want to wait until we resolve them to merge this

@roaga
Copy link
Member Author

roaga commented Nov 8, 2024

I think the team has some concerns with moving resources into its own section in the sidebar - probably want to wait until we resolve them to merge this

Oh is Vu's Figma design not final? I can't really move forward with the Autofix EA UI work if I can't move out the Resources section.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...views/issueDetails/streamline/resourcesSection.tsx 0.00% 5 Missing ⚠️
...ic/app/views/issueDetails/streamline/resources.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #80507   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files        7202     7203    +1     
  Lines      318713   318719    +6     
  Branches    43926    43927    +1     
=======================================
+ Hits       249700   249712   +12     
+ Misses      62650    62644    -6     
  Partials     6363     6363           

@vuluongj20
Copy link
Member

@roggenkemper We decided to separate resources and solutions from the consolidated Solutions Center (name WIP). That way the Solutions Center can be GenAI/AI content only, and we can have a single onboarding flow for it.

@roggenkemper
Copy link
Member

@roggenkemper We decided to separate resources and solutions from the consolidated Solutions Center (name WIP). That way the Solutions Center can be GenAI/AI content only, and we can have a single onboarding flow for it.

@vuluongj20 Matt brought up a similar concern earlier today, but having the resources on the page (not collapsed/collapsible/in a flyout) means that first/last seen is moved further down and becomes harder to find. We also have resources for non-performance issues so in those cases the first/last seen is really pushed down.

@vuluongj20
Copy link
Member

@roggenkemper Hmm that's fair. Let's discuss what we can do to limit the impact. I do still think it's worth separating Resources from the Solutions Center, cause otherwise given that most of the Solutions Center is AI-generated content, users may be misled into thinking that Resources too was AI-generated.

@roaga roaga closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants