ref(sentry apps): Don't pass in event for send_alert_event #80263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Christinarlong
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80263 +/- ##
===========================================
+ Coverage 51.11% 78.08% +26.97%
===========================================
Files 7154 7185 +31
Lines 315858 317308 +1450
Branches 43555 43732 +177
===========================================
+ Hits 161444 247781 +86337
+ Misses 153294 63183 -90111
- Partials 1120 6344 +5224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor send_alert_event to get event data & IssueOccurance from nodestore
This task occurs like 3/s in US (compared to 500/s for send_process_resource_change) so shouldn't hit any rate limits