Repository navigation
feat(workflow_engine): Return status change messages when a stateful detector resolves - #80122
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
wedamija
force-pushed
the
danf/we-condition-eval
branch
from
November 2, 2024 00:59
a018976 to
f2d261c
Compare
wedamija
force-pushed
the
danf/we-return-status-changes
branch
from
November 2, 2024 00:59
b3513f6 to
f196c85
Compare
ceorourke
reviewed
Nov 4, 2024
ceorourke
approved these changes
Nov 4, 2024
saponifi3d
approved these changes
Nov 5, 2024
|
|
||
| @property | ||
| def project_id(self): | ||
| # XXX: Temporary property until we add `project_id` to the model. |
Contributor
There was a problem hiding this comment.
any other properties that we should add? I have a few more things from process_workflows as well, but going to hold off until these PRs are merged before looking at those more. (active is on my list to remove as well.)
Member
Author
There was a problem hiding this comment.
Where are you removing active from?
I don't know of any other properties right now, but if I think of any I'll slack them over to you
| if state_data.active != is_active or state_data.status != status: | ||
| self.enqueue_state_update(group_key, is_active, status) | ||
| # TODO: Add hook here for generating occurrence or status update | ||
| if state_data.status != new_status: |
wedamija
force-pushed
the
danf/we-condition-eval
branch
2 times, most recently
from
November 5, 2024 18:31
d652913 to
0d47d69
Compare
wedamija
force-pushed
the
danf/we-return-status-changes
branch
from
November 5, 2024 18:32
f196c85 to
230aa8e
Compare
wedamija
force-pushed
the
danf/we-condition-eval
branch
from
November 5, 2024 18:51
0d47d69 to
ef2e3ab
Compare
wedamija
force-pushed
the
danf/we-return-status-changes
branch
from
November 5, 2024 18:51
230aa8e to
9d0bb76
Compare
wedamija
force-pushed
the
danf/we-condition-eval
branch
from
November 5, 2024 20:08
ef2e3ab to
e765cd6
Compare
wedamija
force-pushed
the
danf/we-return-status-changes
branch
from
November 5, 2024 20:08
551778e to
0f99ed3
Compare
wedamija
force-pushed
the
danf/we-condition-eval
branch
from
November 5, 2024 20:49
e765cd6 to
9f9637a
Compare
wedamija
force-pushed
the
danf/we-return-status-changes
branch
from
November 5, 2024 20:49
0f99ed3 to
64effae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80122 +/- ##
==========================================
- Coverage 78.09% 78.09% -0.01%
==========================================
Files 7185 7185
Lines 317425 317435 +10
Branches 43747 43748 +1
==========================================
+ Hits 247894 247896 +2
- Misses 63192 63198 +6
- Partials 6339 6341 +2 |
…detector resolves When we detect that a stateful detector has resolved we can return a resolved status change message. This is generic and applies to all stateful detectors, so there's no need for customization here.
wedamija
force-pushed
the
danf/we-return-status-changes
branch
from
November 5, 2024 21:34
64effae to
b87fe97
Compare
jan-auer
added a commit
that referenced
this pull request
Nov 6, 2024
* master: (67 commits) feat(dynamic-sampling): Sampling breakdown (#80304) feat(profiling): add organizations:continuous-profiling to the list of exposable features (#80236) chore(broadcasts): remove cta column from broadcast model (#80201) feat(dynamic-sampling): Use sample rates endpoint (#80235) feat(issues): Rearrange all events columns, sizes (#80296) fix(issues): All event table pagination counts (#80297) fix(issues): Preserve query parameters on all events close (#80295) feat(issues): Hide "comment" button until focused (#80283) fix(sentry-app): Adds better validation for invalid token request bodies (#80289) feat(workflow_engine): Add in hook for producing occurrences from the stateful detector (#80168) feat(issue summary) New structured issue summary design (#80273) feat(workflow_engine): Return status change messages when a stateful detector resolves (#80122) feat(insights): Add insights query date range footer hook (#80276) ref(crons): Switch to cronsim in sample data generator (#80278) feat(issue-details): Hide merged/similar issues for non-error issues (#80284) feat(issue summary) Update issue summary model (#80270) feat(crons): Add cronsim behind an option (#80271) fix(anomaly detection): add alerts analytics reqs to utils/analytics.tsx (#80281) feat(trace-explorer): Sort traces by timestamp in EAP (#80274) feat(workflow_engine): Implement basic evaluation in `DataCondition` (#80118) ...
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we detect that a stateful detector has resolved we can return a resolved status change message. This is generic and applies to all stateful detectors, so there's no need for customization here.